feat(sdk-trace-web,fetch,grpc,http,xml-http-request): only emit stable http metrics, spans and attributes - #6819
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6819 +/- ##
==========================================
- Coverage 95.14% 95.08% -0.07%
==========================================
Files 397 394 -3
Lines 14254 13992 -262
Branches 3296 3223 -73
==========================================
- Hits 13562 13304 -258
+ Misses 692 688 -4
🚀 New features to boost your workflow:
|
|
This also fixes #2353 since the code that causes this will be removed and the bug does not exist for the new semantic conventions. I'll link it. |
pichlermarc
left a comment
There was a problem hiding this comment.
Thank you for working on this 🙌
I think the title needs to be updated (we're not only emitting stable-only metrics but also spans and their attributes follow the new semconv with this change).
|
@pichlermarc let me know if you want any other changes. |
pichlermarc
left a comment
There was a problem hiding this comment.
Looks good, just a few smaller things (see comments below):
Looks like there's a dead-code enum in experimental/packages/opentelemetry-instrumentation-xml-http-request/src/enums/AttributeNames.ts that can now be removed :)
|
Comments addressed |
pichlermarc
left a comment
There was a problem hiding this comment.
thank you for working on this 🙌
|
@maryliag - from a release-scheduling perspective it would be great to also have PR that's ready-to-merge on the contrib repo. When we release here, we also have to release contrib, which means if we don't have changes ready users may still have some My preferred way to get this out to the users would be:
(since 2 and 3 should happen on the same day, otherwise some packages may be incompatible with each other due to breaking changes and that blocks users from upgrading - we've seen this in the past) This way we also have one "rip the band-aid off" break for HTTP semconv instead of having it spread out over multiple releases |
|
sounds good! I'll open the PR in contrib soon |
Part Of #6240
Fixes #2353