feat!: only emit stable http, network and database attributes - #3585
Conversation
overbalance
left a comment
There was a problem hiding this comment.
Browser 👌
Two suggestions and a question: Should we be importing attributes in test files or hardcoding the values when asserting? Hardcoding seems safer. I see a mix of both already...
Co-authored-by: Jared Freeze <overbalance@users.noreply.github.com>
Co-authored-by: Jared Freeze <overbalance@users.noreply.github.com>
…trib into stable-http
The majority uses the attributes from semconv, so I tried to keep it that way |
There was a problem hiding this comment.
Thank you for working on this. 🎉
I see db.client.connections.usage (which is deprecated) is still emitted by @opentelemetry/instrumentation-mysql and @opentelemetry/instrumentation-mongodb - but the replacement metric db.client.connection.count is still in-development.
WDYT: Should we just unconditionally emit db.client.connection.count instead like @opentelemetry/instrumentation-pg already does? Seems to be the least breaking way to me without having to have a flag that users have to flip on. Downside: if that metric changes we may have to break users again.
Edit: nevermind; I just saw the linked issue (#3590) so you had already noticed the same 😅
|
What I was thinking is that ideally the metric would be replaced with the new one, so I was planning on doing that on a follow-up PR from this one. Then we can decide if is okay to have the breaking change before the 3.0 or wait for that to have the new PR merged. |
Part Of open-telemetry/opentelemetry-js#6240
Affected packages: