Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Add extra logging when System.Title is too long#3332

Merged
kananb merged 1 commit into from
Jul 24, 2023
Merged

Add extra logging when System.Title is too long #3332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ApiService/ApiService/onefuzzlib/notifications/Ado.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,13 @@ private async Async.Task<WorkItem> CreateNew() {
);
// try to avoid naming collisions caused by the trim by appending the first 8 characters of the title's hash at the end
_config.AdoFields["System.Title"] = $"{systemTitle[..(MAX_SYSTEM_TITLE_LENGTH - 14)]}... [{systemTitleHashString[..8]}]";
_logTracer.LogInformation(

@mgreisen mgreisen Jul 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often is this going to be logged?

@kananb kananb Jul 24, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As often as we're currently seeing those System.Title too long errors
"System.Title \"{Title}\" was too long ({TitleLength} chars); shortend it to \"{NewTitle}\" ({NewTitleLength} chars)",
systemTitle,
systemTitle.Length,
_config.AdoFields["System.Title"],
_config.AdoFields["System.Title"].Length
);
}

foreach (var field in _config.AdoFields.Keys) {
Expand Down