This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Add extra logging when System.Title is too long#3332
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3332 +/- ##
==========================================
- Coverage 31.81% 30.40% -1.41%
==========================================
Files 307 133 -174
Lines 37327 14285 -23042
==========================================
- Hits 11874 4343 -7531
+ Misses 25453 9942 -15511
|
chkeita
approved these changes
Jul 24, 2023
tevoinea
approved these changes
Jul 24, 2023
mgreisen
reviewed
Jul 24, 2023
| ); | ||
| // try to avoid naming collisions caused by the trim by appending the first 8 characters of the title's hash at the end | ||
| _config.AdoFields["System.Title"] = $"{systemTitle[..(MAX_SYSTEM_TITLE_LENGTH - 14)]}... [{systemTitleHashString[..8]}]"; | ||
| _logTracer.LogInformation( |
Contributor
There was a problem hiding this comment.
How often is this going to be logged?
Contributor
Author
There was a problem hiding this comment.
As often as we're currently seeing those System.Title too long errors
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add an info-level trace when trimming the System.Title.
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?