[FG:InPlacePodVerticalScaling] Remove restrictions on subresource flag in kubectl commands

[AnishShah]

What type of PR is this?

/kind feature
/sig cli

What this PR does / why we need it:

We are introducing a new resize subresource in #128266. We would like to add support for this subresource in kubectl. We are doing this by removing restrictions on the subresource flag instead of adding resize to the allowlist.

Which issue(s) this PR fixes:

Fixes #128278

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed restrictions on subresource flag in kubectl commands

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1287-in-place-update-pod-resources

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tallclair]

With the removal of these restrictions, what happens if these commands are used on a subresource that takes a different schema? for example edit a replicaset/scale, or apply a pod/bind?

[AnishShah]

lgtm, if we're removing the hard-coded limits on which subresources support these, should AddSubresourceFlags stop taking an allowedSubresources param?

I removed this param.

With the removal of these restrictions, what happens if these commands are used on a subresource that takes a different schema? for example edit a replicaset/scale, or apply a pod/bind?

I got this error:

kubectl patch pod pause -p '{"metadata":{"labels":{"env":"staging"}}}' --subresource=bind  
Error from server (NotFound): the server could not find the requested resource

[liggitt]

With the removal of these restrictions, what happens if these commands are used on a subresource that takes a different schema? for example edit a replicaset/scale, or apply a pod/bind?

I got this error:

kubectl patch pod pause -p '{"metadata":{"labels":{"env":"staging"}}}' --subresource=bind  
Error from server (NotFound): the server could not find the requested resource

Right, the operations just attempt to operate on the subresource specified... if the subresource doesn't exist or the submitted operation isn't valid for that subresource, it'll error.

[tallclair]

/milestone v1.32

[AnishShah]

kind ping @ardaguclu @soltysh since we are a few days away from code freeze.

#128266 is approved and ready to be merged. It would be good to get feedback on this PR so that the user can leverage new subresource via kubectl.

[ardaguclu]

Thank you
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 3c9834c7a9debbcf891f4466eaee9f0d4710f599

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AnishShah, ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[esotsal]

I think it is imperative to go through the documentation and update parts where patch is mentioned for InPlacePodVerticalScaling and update examples with the new approach. I was hit by this being unaware of the change, i assume others will be as well. posted in slack this, to create awareness, try to gather feedback and accelerate the process of writing equivalents, thanks @AnishShah for letting me know.