Skip to content

KEP-2590: update supported subresources list - #5179

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
soltysh:subresource_update
Feb 20, 2025
Merged

KEP-2590: update supported subresources list#5179
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
soltysh:subresource_update

Conversation

@soltysh

@soltysh soltysh commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Feb 18, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2025
@soltysh soltysh mentioned this pull request Feb 18, 2025
12 tasks
This document proposes adding a new `--subresource` flag to the following kubectl
subcommands: `get`, `patch`, `edit`, `apply` and `replace`. The goal of this flag
is to simplify the process of fetching and updating `status` and `scale` subresources.
is to simplify the process of fetching and updating `status`, `scale` and `resize`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better if we add resize KEP in kep.yaml references?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but not blocker.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@ardaguclu

Copy link
Copy Markdown
Member

/lgtm
/hold
feel free to unhold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 20, 2025
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
@soltysh

soltysh commented Feb 20, 2025

Copy link
Copy Markdown
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2025
@ardaguclu

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@k8s-ci-robot
k8s-ci-robot merged commit 1b8586d into kubernetes:master Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 20, 2025
@soltysh
soltysh deleted the subresource_update branch February 20, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants