Skip to content

fix(workout-session): mark all sets completed when finishing a session#218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evan188199-tech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(workout-session): mark all sets completed when finishing a session #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/features/workout-session/model/workout-session.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,30 @@ export const useWorkoutSessionStore = create<WorkoutSessionState>((set, get) =>
const { session } = get();

if (session) {
workoutSessionLocal.update(session.id, { status: "completed", endedAt: new Date().toISOString() });
console.log({
session: { ...session, status: "completed", endedAt: new Date().toISOString() },
progress: {},
elapsedTime: 0,
isTimerRunning: false,
isWorkoutActive: false,
const endedAt = new Date().toISOString();

// Mark every set as completed so analytics (volume, ACWR, completion
// stats) account for the work done. Without this, sessions wrapped up via
// "Finish Session" instead of finishing each set keep sets at
// completed: false and become invisible to those calculations.
const completedExercises = session.exercises.map((exercise) => ({
...exercise,
sets: exercise.sets.map((set) => ({ ...set, completed: true })),
}));

workoutSessionLocal.update(session.id, {
exercises: completedExercises,
status: "completed",
endedAt,
});

set({
session: { ...session, status: "completed", endedAt: new Date().toISOString() },
session: {
...session,
exercises: completedExercises,
status: "completed",
endedAt,
},
progress: {},
elapsedTime: 0,
isTimerRunning: false,
Expand Down