fix(workout-session): mark all sets completed when finishing a session - #218
Open
evan188199-tech wants to merge 1 commit into
Open
fix(workout-session): mark all sets completed when finishing a session#218evan188199-tech wants to merge 1 commit into
evan188199-tech wants to merge 1 commit into
Conversation
`completeWorkout()` only updated session-level fields (`status`, `endedAt`) and never touched the per-set `completed` flag. Sessions wrapped up via "Finish Session" instead of finishing each set therefore kept `set.completed = false`, making them invisible to analytics that filter on `set.completed` (volume, ACWR fatigue, completion stats). Mark every set in the session as `completed: true` and persist the updated exercises alongside the session status. Also drop a leftover debug `console.log` in the same function. Fixes Snouzy#212
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
此 PR 由 GLM-5.2 修复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a user finishes a workout via Finish Session (the overall session-end button) without first clicking Finish Set on every set, the session is marked
status: \"completed\"withendedAtset, but the individual sets keepcompleted: false.Why
completeWorkout()updated only session-level fields and never touched the per-setcompletedflag. Analytics that filter onset.completedtherefore miss these sessions entirely:weightKg × repsovercompleted: truesets) report zeroChanges
In
completeWorkout(), mark every set in the session ascompleted: trueand persist the updatedexercisesalongside the session status/endedAt. Also removed a leftover debugconsole.login the same function.Fixes #212.