feat: use import.meta.ROLLDOWN_FILE_URL_* for assets in JS - #22888
Open
sapphi-red wants to merge 3 commits into
Open
feat: use import.meta.ROLLDOWN_FILE_URL_* for assets in JS#22888sapphi-red wants to merge 3 commits into
import.meta.ROLLDOWN_FILE_URL_* for assets in JS#22888sapphi-red wants to merge 3 commits into
Conversation
sapphi-red
changed the title
import.meta.ROLLUP_FILE_URL_* for assets in JSimport.meta.ROLLDOWN_FILE_URL_* for assets in JS
sapphi-red
force-pushed
the
feat/use-rollup-file-url-for-assets-in-js
branch
from
July 31, 2026 07:54
2f1bf1f to
0cf8fd6
Compare
sapphi-red
force-pushed
the
feat/use-rollup-file-url-for-assets-in-js
branch
from
July 31, 2026 08:43
0cf8fd6 to
b0c338e
Compare
sapphi-red
marked this pull request as ready for review
July 31, 2026 09:46
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the "Use of
import.meta.ROLLUP_FILE_URL_referenceId" in #22709 (comment)This change allows Rolldown plugins using
import.meta.ROLLDOWN_FILE_URL_*to work well with thebaseoption andrenderBuiltUrloption. But this does not convert URL of those assets to data URL. For that #22709 (comment) is needed.This PR migrates the asset plugin to use that approach.