Skip to content

bump go/golangci-lint and clean ci - #548

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
cpanato:updates
Mar 6, 2026
Merged

bump go/golangci-lint and clean ci#548
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
cpanato:updates

Conversation

@cpanato

@cpanato cpanato commented Feb 20, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • bump go to 1.25.7
  • bump golangci-lint
  • clean up ci

/hold

need test-infra job update first:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

bump go/golangci-lint and clean ci

Additional documentation e.g., Usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 20, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2026
@cpanato

cpanato commented Feb 20, 2026

Copy link
Copy Markdown
Member Author

/assign @vladimirvivien @harshanarayana

@vladimirvivien vladimirvivien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @cpanato

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2026
@vladimirvivien

Copy link
Copy Markdown
Contributor

/retest

@vladimirvivien

Copy link
Copy Markdown
Contributor

@cpanato it looks like golangci-lint introduced new rules causing failures. Ping me if you need assistance.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2026
Signed-off-by: Carlos Panato <ctadeu@gmail.com>

@vladimirvivien vladimirvivien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cpanato,vladimirvivien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato

cpanato commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 5bfe623 into kubernetes-sigs:main Mar 6, 2026
4 checks passed
@cpanato
cpanato deleted the updates branch March 6, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants