Skip to content

fix: export mise path entries to subsequent steps - #575

Merged
jdx merged 2 commits into
mainfrom
codex/export-mise-path
Jul 24, 2026
Merged

fix: export mise path entries to subsequent steps#575
jdx merged 2 commits into
mainfrom
codex/export-mise-path

Conversation

@jdx

@jdx jdx commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • restore activation-like propagation of mise-produced PATH entries to subsequent workflow steps
  • add only the PATH prefix introduced by mise through GITHUB_PATH, without exporting the runner's complete computed PATH through GITHUB_ENV
  • enable PATH export by default for compatibility with behavior users relied on before v4.2.1
  • add export_path: false as an explicit opt-out
  • cover configured PATH ordering across Linux, macOS, Windows, and Alpine, plus the opt-out behavior

Root cause

v4.2.1 correctly stopped exporting the complete PATH returned by mise env --json, which had snapshotted the runner environment into GITHUB_ENV. However, removing PATH entirely also removed [env] _.path and other mise-produced path entries that users relied on in subsequent steps.

This change computes the prefix that mise added to the action's existing PATH and forwards those directories individually using the GitHub Actions PATH environment file. It retains mise's configured ordering while avoiding the unsafe full-PATH export.

Addresses #565.

Validation

  • aube install
  • aubr all
  • mise x actionlint@1.7.12 shellcheck@0.11.0 -- actionlint .github/workflows/test.yml
  • mise x shellcheck@0.11.0 -- shellcheck scripts/test.sh

This pull request was generated by Codex.


Note

Medium Risk
Touches how every workflow step sees PATH after setup; logic is nuanced (prefix vs set-diff) but defaults preserve prior behavior and CI covers ordering and opt-out.

Overview
Restores activation-like PATH propagation for subsequent workflow steps after v4.2.1 stopped exporting PATH entirely. The action now derives only the prefix mise added to the current PATH (tools, [env] _.path, etc.) and appends those entries through GITHUB_PATH, instead of writing the full computed PATH into GITHUB_ENV.

Adds export_path (default true) so workflows can keep regular env exports while opting out of PATH changes. Dotenv fallbacks strip PATH from GITHUB_ENV and still export additions via JSON when needed.

CI creates ordered PATH fixtures across the matrix and adds a path_opt_out job; scripts/test.sh checks [env] _.path ordering persists in later steps.

Reviewed by Cursor Bugbot for commit 30d9042. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jdx, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: bb3fafbb-b5da-4d43-897f-550bc26e0ba1

📥 Commits

Reviewing files that changed from the base of the PR and between f10502f and 30d9042.

⛔ Files ignored due to path filters (2)
  • dist/index.js is excluded by !**/dist/**
  • dist/index.js.map is excluded by !**/dist/**, !**/*.map
📒 Files selected for processing (5)
  • .github/workflows/test.yml
  • README.md
  • action.yml
  • scripts/test.sh
  • src/index.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5fcf8d2. Configure here.

Comment thread dist/index.js
@greptile-apps

greptile-apps Bot commented Jul 24, 2026

Copy link
Copy Markdown

Greptile Summary

Restores propagation of mise-produced PATH entries to subsequent workflow steps.

  • Filters PATH from legacy dotenv output instead of writing the complete computed PATH to GITHUB_ENV.
  • Adds mise-specific PATH entries through GITHUB_PATH, with an export_path opt-out.
  • Updates action metadata, documentation, bundled artifacts, and cross-platform workflow tests.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains within the scope of the previous review thread.

Important Files Changed

Filename Overview
src/index.ts Separates PATH from regular environment export, filters PATH from legacy dotenv output, and propagates mise-added entries through GITHUB_PATH.
action.yml Declares the new export_path input and updates the env input contract.
.github/workflows/test.yml Adds PATH-ordering fixtures and verifies the legacy-version opt-out behavior.
scripts/test.sh Updates integration assertions to require mise-configured PATH precedence.
dist/index.js Includes the bundled runtime implementation corresponding to the TypeScript changes.

Reviews (2): Last reviewed commit: "fix: filter path from dotenv fallback" | Re-trigger Greptile

Comment thread src/index.ts
@jdx
jdx merged commit 0f85637 into main Jul 24, 2026
21 checks passed
@jdx
jdx deleted the codex/export-mise-path branch July 24, 2026 18:37
@jdx jdx mentioned this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant