fix: export mise path entries to subsequent steps - #575
Conversation
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5fcf8d2. Configure here.
Greptile SummaryRestores propagation of mise-produced PATH entries to subsequent workflow steps.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains within the scope of the previous review thread. Important Files Changed
Reviews (2): Last reviewed commit: "fix: filter path from dotenv fallback" | Re-trigger Greptile |

Summary
GITHUB_PATH, without exporting the runner's complete computed PATH throughGITHUB_ENVexport_path: falseas an explicit opt-outRoot cause
v4.2.1 correctly stopped exporting the complete PATH returned by
mise env --json, which had snapshotted the runner environment intoGITHUB_ENV. However, removing PATH entirely also removed[env] _.pathand other mise-produced path entries that users relied on in subsequent steps.This change computes the prefix that mise added to the action's existing PATH and forwards those directories individually using the GitHub Actions PATH environment file. It retains mise's configured ordering while avoiding the unsafe full-PATH export.
Addresses #565.
Validation
aube installaubr allmise x actionlint@1.7.12 shellcheck@0.11.0 -- actionlint .github/workflows/test.ymlmise x shellcheck@0.11.0 -- shellcheck scripts/test.shThis pull request was generated by Codex.
Note
Medium Risk
Touches how every workflow step sees PATH after setup; logic is nuanced (prefix vs set-diff) but defaults preserve prior behavior and CI covers ordering and opt-out.
Overview
Restores activation-like PATH propagation for subsequent workflow steps after v4.2.1 stopped exporting PATH entirely. The action now derives only the prefix mise added to the current
PATH(tools,[env] _.path, etc.) and appends those entries throughGITHUB_PATH, instead of writing the full computedPATHintoGITHUB_ENV.Adds
export_path(defaulttrue) so workflows can keep regularenvexports while opting out of PATH changes. Dotenv fallbacks stripPATHfromGITHUB_ENVand still export additions via JSON when needed.CI creates ordered PATH fixtures across the matrix and adds a
path_opt_outjob;scripts/test.shchecks[env] _.pathordering persists in later steps.Reviewed by Cursor Bugbot for commit 30d9042. Bugbot is set up for automated code reviews on this repo. Configure here.