feat!: Update Node.js version from 20 to 24 - #395
Conversation
This PR updates the GitHub Actions runner environment to use Node.js 24, following the deprecation notice for Node.js 20. GitHub has announced that starting June 2, 2026, Node.js 24 will become the default, and earlier versions will be restricted to ensure security and performance standards. The jdx/mise-action@v3 currently triggers a deprecation warning because it defaults to the Node.js 20 runtime. To proactively address this and avoid potential workflow failures during the transition period, we are opting into the newer runtime version now.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request proactively updates the Node.js runtime used by the GitHub Actions runner environment from version 20 to 24. This change is in response to GitHub's announcement regarding the deprecation of Node.js 20 and the upcoming default to Node.js 24, ensuring continued security, performance, and avoiding potential workflow disruptions. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Greptile SummaryThis PR completes the Node.js 24 migration for Key points:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Workflow triggers mise-action] --> B{GitHub Actions Runner}
B --> C["Reads action.yml\n'using: node24'"]
C --> D["Executes dist/index.js\nwith Node.js 24 runtime"]
D --> E[Downloads & installs mise]
E --> F[Configures PATH & env vars]
F --> G[Runs 'mise install']
G --> H[Exports GITHUB_ENV vars]
style C fill:#22c55e,color:#fff
style D fill:#22c55e,color:#fff
subgraph "Before PR"
B1["using: node20"] -.-> D1["Node.js 20 runtime"]
end
subgraph "After PR"
B2["using: node24"] --> D2["Node.js 24 runtime"]
end
Last reviewed commit: 0cc6425 |
There was a problem hiding this comment.
Code Review
This pull request attempts to update the Node.js runtime for the action from node20 to node24. However, node24 is not a supported runtime in GitHub Actions at this time. The correct runtime to use after node20 is node22. The current change will break the action for all users. I have provided a comment with a suggestion to correct the runtime version.
| description: A boolean value to indicate if a cache was hit. | ||
| runs: | ||
| using: node20 | ||
| using: node24 |
There was a problem hiding this comment.
The assertion that node24 is unsupported is incorrect based on the latest GitHub runner deprecation schedule.
-
Official Deprecation Notice: GitHub has issued a formal warning for jdx/mise-action@v3 (and other Node 20 actions), explicitly stating: "Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026."
-
Opt-in Mechanism: GitHub currently supports an immediate opt-in to the Node 24 runtime via the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable.
-
Migration Path: While Node 22 is an LTS release, GitHub's specific runner implementation is tracking Node 24 for the 2026 default cutoff. Moving to node22 now would only necessitate another migration in the near future, whereas node24 aligns with the final 2026 requirement.
|
Not a maintainer, but I have two notes on this:
|
--- ## [4.0.0](https://github.com/jdx/mise-action/compare/v3.6.3..v4.0.0) - 2026-03-13 ### 🚀 Features - **breaking** Update Node.js version from 20 to 24 (#395) by [@tumerorkun](https://github.com/tumerorkun) in [#395](#395) ### New Contributors * @tumerorkun made their first contribution in [#395](#395) <!-- generated by git-cliff -->
Fixes #394
This PR updates the GitHub Actions runner environment to use Node.js 24, following the deprecation notice for Node.js 20. GitHub has announced that starting June 2, 2026, Node.js 24 will become the default, and earlier versions will be restricted to ensure security and performance standards.
The jdx/mise-action@v3 currently triggers a deprecation warning because it defaults to the Node.js 20 runtime. To proactively address this and avoid potential workflow failures during the transition period, we are opting into the newer runtime version now.