Fix TextBuilder stack overflow with many attributed runs#65
Merged
gonzalezreal merged 1 commit intoJun 14, 2026
Merged
Conversation
Owner
|
Hi @markawilliamson, Thanks for the fix and the regression test! ❤️ |
This was referenced Jun 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Textfragments withpartialResult + textinstead of localized interpolationThis avoids building a recursively nested
LocalizedStringKey/Textinterpolation tree whenTextBuildercombines many attributed runs.Fixes #64.
Testing
swift test --filter TextBuilderTestsswift test --skip CodeTokenizerTestsI also ran unfiltered
swift test; it built successfully but my local run failed in the existingCodeTokenizerTestsbecause the tokenizer wasnil, unrelated to this change.