Skip to content

fix(ppdb): Parse streams in the correct order#760

Merged
loewenheim merged 4 commits into
masterfrom
fix/ppdb-stream-order
Feb 16, 2023
Merged

fix(ppdb): Parse streams in the correct order#760
loewenheim merged 4 commits into
masterfrom
fix/ppdb-stream-order

Conversation

@loewenheim

Copy link
Copy Markdown
Contributor

Ppdb parsing incorrectly assumed that the #Pdb stream would always be physically located before the #~ stream and just parsed them in order. Since the #Pdb stream contains table size information that must be known during #~ parsing, this led to the bug described in #759.

The fix is simply to initially collect the locations of all the streams and then parse the #Pdb stream before the others.

@loewenheim loewenheim requested a review from a team February 16, 2023 12:32
@loewenheim loewenheim self-assigned this Feb 16, 2023
@loewenheim loewenheim linked an issue Feb 16, 2023 that may be closed by this pull request
Comment thread symbolic-ppdb/src/format/mod.rs Outdated
@loewenheim loewenheim enabled auto-merge (squash) February 16, 2023 13:23
@codecov

codecov Bot commented Feb 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #760 (d9de028) into master (a14f0e2) will increase coverage by 0.01%.
The diff coverage is 90.90%.

❗ Current head d9de028 differs from pull request most recent head e8f8d6c. Consider uploading reports for the commit e8f8d6c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   73.89%   73.90%   +0.01%     
==========================================
  Files          69       69              
  Lines       14949    14952       +3     
==========================================
+ Hits        11047    11051       +4     
+ Misses       3902     3901       -1     

@loewenheim loewenheim merged commit 23a9351 into master Feb 16, 2023
@loewenheim loewenheim deleted the fix/ppdb-stream-order branch February 16, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Portable PDB reader row-size broken for MAUI

2 participants