Skip to content

[pydocstyle] Fix D413 infinite loop for parenthesized docstring#18930

Merged
ntBre merged 3 commits into
astral-sh:mainfrom
danparizher:fix-18908
Jun 30, 2025
Merged

[pydocstyle] Fix D413 infinite loop for parenthesized docstring#18930
ntBre merged 3 commits into
astral-sh:mainfrom
danparizher:fix-18908

Conversation

@danparizher

Copy link
Copy Markdown
Contributor

Summary

Fixes #18908

@github-actions

github-actions Bot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre added bug Something isn't working docstring Related to docstring linting or formatting fixes Related to suggested fixes for violations labels Jun 25, 2025
@ntBre

ntBre commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Could you add a test showing that the issue is fixed?

@danparizher

Copy link
Copy Markdown
Contributor Author

Could you add a test showing that the issue is fixed?

Added the case from the original issue

@ntBre ntBre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. Just one question about the change on line 1609.

Comment thread crates/ruff_linter/src/rules/pydocstyle/rules/sections.rs Outdated
@ntBre ntBre merged commit 9f0d3cc into astral-sh:main Jun 30, 2025
35 checks passed
@danparizher danparizher deleted the fix-18908 branch June 30, 2025 14:56
iyakushev pushed a commit to iyakushev/ruff that referenced this pull request Jul 1, 2025
…tral-sh#18930)

<!--
Thank you for contributing to Ruff/ty! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title? (Please prefix
with `[ty]` for ty pull
  requests.)
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->

Fixes astral-sh#18908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working docstring Related to docstring linting or formatting fixes Related to suggested fixes for violations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Infinite loop] D413 fix for parenthesized docstring

2 participants