Skip to content

Add support for vertex color attributes to AccessorUtility#1398

Merged
j9liu merged 6 commits into
mainfrom
color-accessor-view
Jun 18, 2026
Merged

Add support for vertex color attributes to AccessorUtility#1398
j9liu merged 6 commits into
mainfrom
color-accessor-view

Conversation

@lilleyse

@lilleyse lilleyse commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

Adds support for vertex color attributes to AccessorUtility.

ColorFromAccessor always returns a glm::dvec4. If the underlying type is VEC3 the alpha channel is set to 1.0.

image

Issue number or link

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Remaining Tasks

Testing plan

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

Base automatically changed from accessor-view-normalized to main June 16, 2026 22:20

@j9liu j9liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lilleyse ! Looks great, I just have a few small comments before merge.

Comment thread CesiumGltf/include/CesiumGltf/AccessorUtility.h Outdated
Comment thread CesiumGltf/src/AccessorUtility.cpp Outdated
Comment thread CesiumGltf/test/TestAccessorUtility.cpp Outdated
@lilleyse

Copy link
Copy Markdown
Contributor Author

@j9liu Thanks! Ready for another review.

@j9liu j9liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lilleyse !

@j9liu j9liu merged commit 54c95e3 into main Jun 18, 2026
28 checks passed
@j9liu j9liu deleted the color-accessor-view branch June 18, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants