Skip to content

Add options to convert unsupported primitive modes when reading glTFs#1392

Open
j9liu wants to merge 14 commits into
image-libraryfrom
convert-primitive-mode
Open

Add options to convert unsupported primitive modes when reading glTFs#1392
j9liu wants to merge 14 commits into
image-libraryfrom
convert-primitive-mode

Conversation

@j9liu

@j9liu j9liu commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

Depends on #1388, so merge that first.

This PR supports (but does not complete) #1321.

A new struct, CesiumGltfReader::MeshPrimitiveModeOptions allows clients to request conversions of LINE_LOOP, LINE_STRIP, TRIANGLE_STRIP, and TRIANGLE_FAN, as they are less likely to be supported.

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Testing plan

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

@j9liu j9liu changed the base branch from main to image-library June 12, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant