Improve warning display UI related to skills - #58838
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
…ead-callout-ui-improve
MartinYe1234
approved these changes
Jun 8, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
This PR tackles how we communicate errors/warnings relative to skills. It touches three major surfaces: callouts in the thread view, menu items in the completion menu, and settings UI. These are all the places where we display something to tell the user a skill might have a problem. In the settings UI, we now clamp the skill description to five lines. And if there's a warning, we show the warning icon and the description in a tooltip when hovering it: <img width="600" alt="Screenshot 2026-06-08 at 10 51@2x" src="https://github.com/user-attachments/assets/1a1233b0-c24a-4082-9fe6-2ab1d00ba9fd" /> In the thread view, we display callouts with the warnings. I simplified the long-description one specifically given we can click on each skill item right there, so no need for a "manage global skills" button or descriptions in each item: <img width="600" alt="Screenshot 2026-06-08 at 10 52@2x" src="https://github.com/user-attachments/assets/4b9aad23-7362-40cd-8ab5-6dfceb46badd" /> In the code completion menu, I removed the icon that appeared at the far right and instead added the ability for it to render a colored warning icon instead of the icon it'd already display in the left; I think this simplifies it nicely: <img width="350" alt="Screenshot 2026-06-08 at 10 53@2x" src="https://github.com/user-attachments/assets/8d0c731a-31a0-4d30-abab-1eb40f61031e" /> Release Notes: - Agent: Improved how we communicate problems relative to skills, in both the agent panel and the settings UI. --------- Co-authored-by: Martin Ye <martin@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tackles how we communicate errors/warnings relative to skills. It touches three major surfaces: callouts in the thread view, menu items in the completion menu, and settings UI. These are all the places where we display something to tell the user a skill might have a problem.
In the settings UI, we now clamp the skill description to five lines. And if there's a warning, we show the warning icon and the description in a tooltip when hovering it:
In the thread view, we display callouts with the warnings. I simplified the long-description one specifically given we can click on each skill item right there, so no need for a "manage global skills" button or descriptions in each item:
In the code completion menu, I removed the icon that appeared at the far right and instead added the ability for it to render a colored warning icon instead of the icon it'd already display in the left; I think this simplifies it nicely:
Release Notes: