settings_ui: Move skills management into settings UI - #58701
Merged
Conversation
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
MartinYe1234
marked this pull request as ready for review
June 5, 2026 22:32
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
- Resolve skill save scope at save time from the selected settings file instead of caching it on every render - Make the Save Skill button call save_skill directly; dispatching the action silently failed when focus was outside the creator - Rename agent::OpenRulesLibrary to agent::ManageSkills with deprecated aliases for existing keymaps - Don't follow redirects on GITHUB_TOKEN-authenticated requests so the token can't leak to another host - Centralize the agent.skills settings path in a shared constant - Bump URL import debounce to 300ms
The Skills page description had a broken sentence, and the commit message customization example still pointed at the removed Rules Library. Point it at the commit_message_instructions agent setting instead, matching docs/src/git.md.
The skill creator computed name and description validation errors but never surfaced them. Add opt-in error support to InputField (red border plus hint subtext) and wire the name and description fields to it, and show the body field's requirement as hint text too, so all three fields flag invalid input consistently.
danilo-leal
approved these changes
Jun 8, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…58701) Closes AI-344 Closes AI-342 Moves agent skills management out of the agent panel and into the settings UI. The skill creator (previously its own crate) now lives in `settings_ui` as a settings page, alongside the skills setup page. The agent panel's ellipsis menu now links to the settings page instead of hosting skill management directly. Release Notes: - Improved agent skills management by moving it into the settings UI --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes AI-344
Closes AI-342
Moves agent skills management out of the agent panel and into the settings UI. The skill creator (previously its own crate) now lives in
settings_uias a settings page, alongside the skills setup page. The agent panel's ellipsis menu now links to the settings page instead of hosting skill management directly.Release Notes: