Skip to content

settings_ui: Move skills management into settings UI - #58701

Merged
MartinYe1234 merged 18 commits into
mainfrom
new-settings-ui-with-skills
Jun 8, 2026
Merged

settings_ui: Move skills management into settings UI#58701
MartinYe1234 merged 18 commits into
mainfrom
new-settings-ui-with-skills

Conversation

@MartinYe1234

@MartinYe1234 MartinYe1234 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Closes AI-344
Closes AI-342

Moves agent skills management out of the agent panel and into the settings UI. The skill creator (previously its own crate) now lives in settings_ui as a settings page, alongside the skills setup page. The agent panel's ellipsis menu now links to the settings page instead of hosting skill management directly.

Release Notes:

  • Improved agent skills management by moving it into the settings UI

MartinYe1234 and others added 8 commits June 5, 2026 14:53
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
@MartinYe1234 MartinYe1234 self-assigned this Jun 5, 2026
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 5, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 5, 2026
@MartinYe1234
MartinYe1234 marked this pull request as ready for review June 5, 2026 22:32
MartinYe1234 and others added 10 commits June 5, 2026 15:45
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
- Resolve skill save scope at save time from the selected settings
  file instead of caching it on every render
- Make the Save Skill button call save_skill directly; dispatching
  the action silently failed when focus was outside the creator
- Rename agent::OpenRulesLibrary to agent::ManageSkills with
  deprecated aliases for existing keymaps
- Don't follow redirects on GITHUB_TOKEN-authenticated requests so
  the token can't leak to another host
- Centralize the agent.skills settings path in a shared constant
- Bump URL import debounce to 300ms
The Skills page description had a broken sentence, and the commit
message customization example still pointed at the removed Rules
Library. Point it at the commit_message_instructions agent setting
instead, matching docs/src/git.md.
The skill creator computed name and description validation errors but
never surfaced them. Add opt-in error support to InputField (red border
plus hint subtext) and wire the name and description fields to it, and
show the body field's requirement as hint text too, so all three fields
flag invalid input consistently.
@MartinYe1234
MartinYe1234 added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 4eebf3f Jun 8, 2026
32 checks passed
@MartinYe1234
MartinYe1234 deleted the new-settings-ui-with-skills branch June 8, 2026 15:01
@WaryaWayne WaryaWayne mentioned this pull request Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…58701)

Closes AI-344
Closes AI-342

Moves agent skills management out of the agent panel and into the
settings UI. The skill creator (previously its own crate) now lives in
`settings_ui` as a settings page, alongside the skills setup page. The
agent panel's ellipsis menu now links to the settings page instead of
hosting skill management directly.

Release Notes:

- Improved agent skills management by moving it into the settings UI

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants