settings_ui: Allow changing settings scope inside sub-pages - #58698
Merged
MartinYe1234 merged 4 commits intoJun 5, 2026
Merged
Conversation
Make the scope segment of sub-page breadcrumbs a dropdown picker so the settings file can be switched without leaving the sub-page (e.g. Skills or per-language pages), preserving the sub-page stack when valid in the new scope. Also clear the search bar when entering a sub-page, except when following a settings deep link.
MartinYe1234
marked this pull request as ready for review
June 5, 2026 20:18
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
danilo-leal
approved these changes
Jun 5, 2026
MartinYe1234
deleted the
martin/ai-343-allow-changing-settings-scope-inside-subpages
branch
June 5, 2026 21:15
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…stries#58698) The settings UI previously required selecting a settings scope (User / project) before entering a sub-page; the scope picker disappeared once inside. This makes the scope switchable from within sub-pages. - The scope segment of the sub-page breadcrumb (e.g. "User / AI / Agent Configuration / Skills") is now a dropdown listing all scopes the sub-page supports (filtered by the sub-page's file mask, intersected across the sub-page stack). Selecting a scope re-renders the sub-page in place — e.g. the Skills page swaps between global and project-local skills. - The sub-page stack is preserved across scope changes when every sub-page in it is valid in the new scope; otherwise it falls back to the regular navigation behavior. - Sub-pages that only support one scope (Tool Permissions, Configure Providers, Feature Flags) keep the static label. - Entering a sub-page now clears the settings search bar so sub-pages show all their items (settings deep links that prefill the search are unaffected). Closes AI-343 Release Notes: - Improved the settings window: sub-pages such as Skills and per-language settings now have a scope picker in the breadcrumb, so you can switch between User and project settings without leaving the page. --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…stries#58698) The settings UI previously required selecting a settings scope (User / project) before entering a sub-page; the scope picker disappeared once inside. This makes the scope switchable from within sub-pages. - The scope segment of the sub-page breadcrumb (e.g. "User / AI / Agent Configuration / Skills") is now a dropdown listing all scopes the sub-page supports (filtered by the sub-page's file mask, intersected across the sub-page stack). Selecting a scope re-renders the sub-page in place — e.g. the Skills page swaps between global and project-local skills. - The sub-page stack is preserved across scope changes when every sub-page in it is valid in the new scope; otherwise it falls back to the regular navigation behavior. - Sub-pages that only support one scope (Tool Permissions, Configure Providers, Feature Flags) keep the static label. - Entering a sub-page now clears the settings search bar so sub-pages show all their items (settings deep links that prefill the search are unaffected). Closes AI-343 Release Notes: - Improved the settings window: sub-pages such as Skills and per-language settings now have a scope picker in the breadcrumb, so you can switch between User and project settings without leaving the page. --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings UI previously required selecting a settings scope (User / project) before entering a sub-page; the scope picker disappeared once inside. This makes the scope switchable from within sub-pages.
Closes AI-343
Release Notes: