Skip to content

Render the first character as the icon in a terminal thread - #58251

Merged
mikayla-maki merged 1 commit into
mainfrom
render-icon-char-in-terminal-threads
Jun 1, 2026
Merged

Render the first character as the icon in a terminal thread#58251
mikayla-maki merged 1 commit into
mainfrom
render-icon-char-in-terminal-threads

Conversation

@mikayla-maki

@mikayla-maki mikayla-maki commented Jun 1, 2026

Copy link
Copy Markdown
Member

This makes terminal agents look much better:

Screenshot 2026-06-01 at 10 35 34 AM Screenshot 2026-06-01 at 10 36 23 AM

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • The first icon in the terminal title will now render in the thread icon slot, when using terminal threads

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 1, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 1, 2026
@mikayla-maki
mikayla-maki force-pushed the render-icon-char-in-terminal-threads branch from 45e05ca to 35514d1 Compare June 1, 2026 17:37
@mikayla-maki
mikayla-maki marked this pull request as ready for review June 1, 2026 17:37
@mikayla-maki
mikayla-maki enabled auto-merge June 1, 2026 17:37
@mikayla-maki
mikayla-maki disabled auto-merge June 1, 2026 17:37
@mikayla-maki
mikayla-maki added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit d5fc4b7 Jun 1, 2026
32 checks passed
@mikayla-maki
mikayla-maki deleted the render-icon-char-in-terminal-threads branch June 1, 2026 18:06
@zed-zippy zed-zippy Bot added the PR state:needs review Used to label PRs that are in need of a post-merge approval label Jun 1, 2026
@rtfeldman

Copy link
Copy Markdown
Contributor

@zed-industries/approved

@zed-zippy zed-zippy Bot removed the PR state:needs review Used to label PRs that are in need of a post-merge approval label Jun 1, 2026
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
…stries#58251)

This makes terminal agents look much better:

<img width="667" height="520" alt="Screenshot 2026-06-01 at 10 35 34 AM"
src="https://github.com/user-attachments/assets/9029ca7d-effe-43e5-b8f4-10b3e42e6cc9"
/>

<img width="767" height="579" alt="Screenshot 2026-06-01 at 10 36 23 AM"
src="https://github.com/user-attachments/assets/d3392f64-ca2c-40d2-9077-b2ac7a51151d"
/>

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- The first icon in the terminal title will now render in the thread
icon slot, when using terminal threads
@PeterlitsZo

PeterlitsZo commented Jun 12, 2026

Copy link
Copy Markdown
截屏2026-06-12 16 31 17

Sorry but it looks weird. Do you @mikayla-maki think is it a bug or not?

This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…stries#58251)

This makes terminal agents look much better:

<img width="667" height="520" alt="Screenshot 2026-06-01 at 10 35 34 AM"
src="https://github.com/user-attachments/assets/9029ca7d-effe-43e5-b8f4-10b3e42e6cc9"
/>

<img width="767" height="579" alt="Screenshot 2026-06-01 at 10 36 23 AM"
src="https://github.com/user-attachments/assets/d3392f64-ca2c-40d2-9077-b2ac7a51151d"
/>

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- The first icon in the terminal title will now render in the thread
icon slot, when using terminal threads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants