Preserve terminal spinners in thread titles - #57983
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
rtfeldman
marked this pull request as ready for review
May 29, 2026 03:45
zed-zippy
Bot
added
the
PR state:needs review
Member
|
@zed-industries/approved |
zed-zippy
Bot
removed
the
PR state:needs review
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
Summary: - Preserve spinner/logo prefixes from live terminal titles when terminal threads have custom titles. - Store raw terminal titles and custom user titles separately, recomposing display titles on demand. - Keep spinner prefixes out of the title editor while preserving sidebar/search display behavior. Tests: - cargo test -p agent_ui test_terminal_custom_title_recomposes_with_live_spinner -- --nocapture - cargo test -p agent_ui test_terminal_title_editor_excludes_spinner_prefix -- --nocapture - cargo test -p sidebar test_agent_panel_terminals_appear_in_sidebar_and_search -- --nocapture Closes AI-304 Release Notes: - Fixed terminal thread titles to preserve animated spinner and logo prefixes after renaming.
This was referenced Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Summary: - Preserve spinner/logo prefixes from live terminal titles when terminal threads have custom titles. - Store raw terminal titles and custom user titles separately, recomposing display titles on demand. - Keep spinner prefixes out of the title editor while preserving sidebar/search display behavior. Tests: - cargo test -p agent_ui test_terminal_custom_title_recomposes_with_live_spinner -- --nocapture - cargo test -p agent_ui test_terminal_title_editor_excludes_spinner_prefix -- --nocapture - cargo test -p sidebar test_agent_panel_terminals_appear_in_sidebar_and_search -- --nocapture Closes AI-304 Release Notes: - Fixed terminal thread titles to preserve animated spinner and logo prefixes after renaming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Tests:
Closes AI-304
Release Notes: