Fix agent thread sidebar covering window buttons - #54755
Merged
danilo-leal merged 3 commits intoApr 24, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
guild
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
## Summary Fixes an oversight in the agent threads archive sidebar's header: on Linux and Windows it only accounted for macOS traffic lights, so the custom window controls (minimize/maximize/close) rendered on top of the sidebar. The main sidebar (`crates/sidebar/src/sidebar.rs::render_sidebar_header`) already handles this correctly — this PR mirrors that pattern in `ThreadsArchiveView::render_header`. ### What changed - `crates/agent_ui/src/threads_archive_view.rs` - `render_header` now computes `traffic_lights`, `left_window_controls`, and `right_window_controls` (matching `sidebar.rs`) and reserves space / renders controls accordingly when not fullscreen. - Added `render_left_window_controls` / `render_right_window_controls` helpers that delegate to `platform_title_bar`. - Imported `workspace::CloseWindow`. - `crates/agent_ui/Cargo.toml` - Added `platform_title_bar` dependency. ### Behavior - macOS (sidebar on left): unchanged — traffic-light padding + divider. - Linux/Windows, sidebar on left: renders left-side window controls inside the header. - Linux/Windows, sidebar on right: renders right-side window controls inside the header. - Fullscreen: no controls rendered, same as before. #### Closes zed-industries#54596 ### Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ### Video [Screencast from 2026-04-24 14-27-51.webm](https://github.com/user-attachments/assets/47009458-2acb-4b65-bff6-d25302a0342e) Release Notes: - Agent: Fixed the threads sidebar overlapping the window control buttons on Linux and Windows. Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
## Summary Fixes an oversight in the agent threads archive sidebar's header: on Linux and Windows it only accounted for macOS traffic lights, so the custom window controls (minimize/maximize/close) rendered on top of the sidebar. The main sidebar (`crates/sidebar/src/sidebar.rs::render_sidebar_header`) already handles this correctly — this PR mirrors that pattern in `ThreadsArchiveView::render_header`. ### What changed - `crates/agent_ui/src/threads_archive_view.rs` - `render_header` now computes `traffic_lights`, `left_window_controls`, and `right_window_controls` (matching `sidebar.rs`) and reserves space / renders controls accordingly when not fullscreen. - Added `render_left_window_controls` / `render_right_window_controls` helpers that delegate to `platform_title_bar`. - Imported `workspace::CloseWindow`. - `crates/agent_ui/Cargo.toml` - Added `platform_title_bar` dependency. ### Behavior - macOS (sidebar on left): unchanged — traffic-light padding + divider. - Linux/Windows, sidebar on left: renders left-side window controls inside the header. - Linux/Windows, sidebar on right: renders right-side window controls inside the header. - Fullscreen: no controls rendered, same as before. #### Closes zed-industries#54596 ### Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ### Video [Screencast from 2026-04-24 14-27-51.webm](https://github.com/user-attachments/assets/47009458-2acb-4b65-bff6-d25302a0342e) Release Notes: - Agent: Fixed the threads sidebar overlapping the window control buttons on Linux and Windows. Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an oversight in the agent threads archive sidebar's header: on Linux and Windows it only accounted for macOS traffic lights, so the custom window controls (minimize/maximize/close) rendered on top of the sidebar. The main sidebar (
crates/sidebar/src/sidebar.rs::render_sidebar_header) already handles this correctly — this PR mirrors that pattern inThreadsArchiveView::render_header.What changed
crates/agent_ui/src/threads_archive_view.rsrender_headernow computestraffic_lights,left_window_controls, andright_window_controls(matchingsidebar.rs) and reserves space / renders controls accordingly when not fullscreen.render_left_window_controls/render_right_window_controlshelpers that delegate toplatform_title_bar.workspace::CloseWindow.crates/agent_ui/Cargo.tomlplatform_title_bardependency.Behavior
Closes #54596
Self-Review Checklist:
Video
Screencast.from.2026-04-24.14-27-51.webm
Release Notes: