Fix autosave on focus change error when switching git diff via command palette - #53920
Closed
OmChillure wants to merge 2 commits into
Closed
Conversation
zed-codeowner-coordinator
Bot
requested review from
benbrandt and
osyvokon
and removed request for
a team
April 14, 2026 17:52
benbrandt
requested review from
a team,
as-cii and
cole-miller
and removed request for
a team,
benbrandt and
osyvokon
April 15, 2026 09:44
Member
|
Thanks for this! I'm going to try and attack the problem from a more holistic angle (seems like #45166 introduced a number of issues; and #51949 fixes some of them). It seems better to take the approach from this PR of deferring auto-saves and use it more consistently, avoiding the need for most of the logic in #51949. |
ConradIrwin
added a commit
that referenced
this pull request
Apr 22, 2026
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
Self-Review Checklist: Closes zed-industries#53863 Updates zed-industries#53920 Updates zed-industries#51949 Updates zed-industries#45166 Release Notes: - Updated auto_save_on_focus_change to handle modals better.
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Self-Review Checklist: Closes zed-industries#53863 Updates zed-industries#53920 Updates zed-industries#51949 Updates zed-industries#45166 Release Notes: - Updated auto_save_on_focus_change to handle modals better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of whats fixed:
Files changed:
Self-Review Checklist:
Closes #53863
Video
Screencast.from.2026-04-14.22-57-12.webm
Release Notes: