agent_ui: Allow selection of commands from tool calls - #50545
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
yeskunall
marked this pull request as draft
March 3, 2026 00:13
zed-community-bot
Bot
added
the
staff
yeskunall
commented
Mar 3, 2026
| } | ||
| } | ||
|
|
||
| pub fn with_buffer_font(mut self, cx: &App) -> Self { |
Member
Author
There was a problem hiding this comment.
Didn’t notice an existing helper for this combo and also didn’t like writing isolated styles like that. The MarkdownStyle::themed() always uses the UI font for base text and the buffer font settings in themed() are only applied to the code_block style, not to paragraph text.
The following is from Opus 4.6:
The manual code is needed because of a GPUI quirk: font family/weight/features propagate through TextRuns (so they go on base_text_style), but font size and line height only cascade through the div tree (so they must go on container_style). That's why the overrides are split across two places.
yeskunall
marked this pull request as ready for review
March 3, 2026 00:24
This was referenced Mar 4, 2026
tomhoule
force-pushed
the
fix-issue-50427-2a2462291680b84f
branch
2 times, most recently
from
April 24, 2026 12:58
133c217 to
f1a4e20
Compare
Contributor
|
I rebased this and did a round of manual testing. As far as I can tell it's working great! |
tomhoule
force-pushed
the
fix-issue-50427-2a2462291680b84f
branch
from
April 24, 2026 13:29
f1a4e20 to
9a83a0b
Compare
zed-zippy
Bot
added
the
PR state:needs review
Contributor
|
Thanks @tomhoule ! Did this make it into v0.233.10+stable.250.350f33871e84d5ed83a403523e9490b9bf014a94? I still can't select text from agent tool call blocks. |
Member
|
@zed-industries/approved @tredondo It did not make the stable cut |
zed-zippy
Bot
removed
the
PR state:needs review
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
…#50545) Closes zed-industries#50427. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) The changes respect your current theme + mimic the existing UI when it comes to font size+weight. <img width="437" height="131" alt="image" src="https://github.com/user-attachments/assets/89f6c5d0-d1a3-478a-88e9-7d203240416d" /> https://github.com/user-attachments/assets/a5fb6c82-fffd-494f-a374-9296d1690736 Release Notes: - Allow selection of commands from tool calls
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
…#50545) Closes zed-industries#50427. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) The changes respect your current theme + mimic the existing UI when it comes to font size+weight. <img width="437" height="131" alt="image" src="https://github.com/user-attachments/assets/89f6c5d0-d1a3-478a-88e9-7d203240416d" /> https://github.com/user-attachments/assets/a5fb6c82-fffd-494f-a374-9296d1690736 Release Notes: - Allow selection of commands from tool calls
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…#50545) Closes zed-industries#50427. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) The changes respect your current theme + mimic the existing UI when it comes to font size+weight. <img width="437" height="131" alt="image" src="https://github.com/user-attachments/assets/89f6c5d0-d1a3-478a-88e9-7d203240416d" /> https://github.com/user-attachments/assets/a5fb6c82-fffd-494f-a374-9296d1690736 Release Notes: - Allow selection of commands from tool calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50427.
Before you mark this PR as ready for review, make sure that you have:
The changes respect your current theme + mimic the existing UI when it comes to font size+weight.
zed.2026-03-02.19.15.48.mp4
Release Notes: