git_ui: Replace commit message generation spinner with a cancel button - #49540
Merged
danilo-leal merged 4 commits intoApr 27, 2026
Conversation
When a model produces poor output during commit message generation, there was no way to cancel it. This replaces the non-interactive spinner with a Stop button that cancels the generation task. Partial generated text is kept in the editor. Partially addresses zed-industries#33556
cla-bot
Bot
added
the
cla-signed
tomhoule
pushed a commit
that referenced
this pull request
Apr 27, 2026
#49540) When a model produces poor output during commit message generation, there was no way to cancel it. This replaces the non-interactive spinner with a Stop button that cancels the generation task. Partial generated text is kept in the editor. Partially addresses #33556 <img width="1200" height="900" alt="2026-02-18-160103_hyprshot" src="https://github.com/user-attachments/assets/760e9681-b374-4f40-a4b1-0bb6775db17c" /> --- Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added a button to stop commit message generation in the git panel --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
ebaah46
pushed a commit
to ebaah46/zed
that referenced
this pull request
May 6, 2026
zed-industries#49540) When a model produces poor output during commit message generation, there was no way to cancel it. This replaces the non-interactive spinner with a Stop button that cancels the generation task. Partial generated text is kept in the editor. Partially addresses zed-industries#33556 <img width="1200" height="900" alt="2026-02-18-160103_hyprshot" src="https://github.com/user-attachments/assets/760e9681-b374-4f40-a4b1-0bb6775db17c" /> --- Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added a button to stop commit message generation in the git panel --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
zed-industries#49540) When a model produces poor output during commit message generation, there was no way to cancel it. This replaces the non-interactive spinner with a Stop button that cancels the generation task. Partial generated text is kept in the editor. Partially addresses zed-industries#33556 <img width="1200" height="900" alt="2026-02-18-160103_hyprshot" src="https://github.com/user-attachments/assets/760e9681-b374-4f40-a4b1-0bb6775db17c" /> --- Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added a button to stop commit message generation in the git panel --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
zed-industries#49540) When a model produces poor output during commit message generation, there was no way to cancel it. This replaces the non-interactive spinner with a Stop button that cancels the generation task. Partial generated text is kept in the editor. Partially addresses zed-industries#33556 <img width="1200" height="900" alt="2026-02-18-160103_hyprshot" src="https://github.com/user-attachments/assets/760e9681-b374-4f40-a4b1-0bb6775db17c" /> --- Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Added a button to stop commit message generation in the git panel --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a model produces poor output during commit message generation, there was no way to cancel it. This replaces the non-interactive spinner with a Stop button that cancels the generation task. Partial generated text is kept in the editor.
Partially addresses #33556
Before you mark this PR as ready for review, make sure that you have:
Release Notes: