Skip to content

Fix Dependabot alerts by upgrading rollup, rimraf and svelte - #5844

Merged
falkoschindler merged 1 commit into
mainfrom
dependabot
Mar 1, 2026
Merged

Fix Dependabot alerts by upgrading rollup, rimraf and svelte#5844
falkoschindler merged 1 commit into
mainfrom
dependabot

Conversation

@falkoschindler

Copy link
Copy Markdown
Contributor

Motivation

Fix Dependabot security alerts for transitive dependency vulnerabilities:

  • minimatch (>= 10.0.0, < 10.2.3): resolved by upgrading rimraf to ^6.1.3, which pulls glob@13 → minimatch@10.2.4
  • svelte (< 5.53.5): resolved by updating the override in json_editor to >=5.53.5
  • rollup upgraded to ^4.59.0 across all elements and examples

Implementation

Bumped rimraf, rollup, and svelte version constraints in all package.json files across nicegui/elements/ and examples/, then regenerated lock files and rebuilt dist bundles.

Progress

  • I chose a meaningful title that completes the sentence: "If applied, this PR will..."
  • The implementation is complete.
  • This is not a security issue.
  • Pytests have been added (or are not necessary).
  • Documentation has been added (or is not necessary).

Note

I would have pushed directly to main, but we better wait for the CI to confirm that nothing after rebundling so many elements.

@falkoschindler falkoschindler added this to the 3.9 milestone Feb 28, 2026
@falkoschindler falkoschindler added dependencies Type/scope: Third party libraries review Status: PR is open and needs review labels Feb 28, 2026

@evnchn evnchn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure so asked Opus to re-build everything and verify. Human notes in bold.


Verification: All dist bundles rebuilt against updated dependencies

Ran npm ci && npm run build (or npm install && npm run build where no lockfile exists) for all 12 folders with changed package.json / package-lock.json:

  • nicegui/elements/: aggrid, codemirror, echart, joystick, json_editor, leaflet, mermaid, plotly, scene, xterm
  • examples/: signature_pad, node_module_integration

Notes:

  • For 8 elements (aggrid, echart, joystick, leaflet, mermaid, plotly, scene, xterm), only devDependencies changed (rollup 4.52→4.59, rimraf 6.0→6.1), so dist output is identical to main — as expected (I initially thought all elements must change)
  • echart required --legacy-peer-deps due to echarts-gl@2.0.9 requiring peer echarts@^5 while package.json specifies echarts@^6 (pre-existing on main, not introduced by this branch, but can we fix one day?)
  • For codemirror and json_editor, dist files differ from main: codemirror due to rollup chunk-hash changes, json_editor due to new overrides (ajv, svelte)
  • Working tree is clean after all rebuilds — committed dist files match fresh build output

@falkoschindler
falkoschindler added this pull request to the merge queue Mar 1, 2026
@evnchn

evnchn commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

echarts-gl for echarts v6 is coming soon: ecomfe/echarts-gl#561

Merged via the queue into main with commit c200afd Mar 1, 2026
7 checks passed
@falkoschindler
falkoschindler deleted the dependabot branch March 1, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Type/scope: Third party libraries review Status: PR is open and needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants