Fix Dependabot alerts by upgrading rollup, rimraf and svelte - #5844
Merged
Conversation
falkoschindler
enabled auto-merge
February 28, 2026 23:44
evnchn
approved these changes
Mar 1, 2026
evnchn
left a comment
Collaborator
There was a problem hiding this comment.
I was not sure so asked Opus to re-build everything and verify. Human notes in bold.
Verification: All dist bundles rebuilt against updated dependencies
Ran npm ci && npm run build (or npm install && npm run build where no lockfile exists) for all 12 folders with changed package.json / package-lock.json:
- nicegui/elements/: aggrid, codemirror, echart, joystick, json_editor, leaflet, mermaid, plotly, scene, xterm
- examples/: signature_pad, node_module_integration
Notes:
- For 8 elements (aggrid, echart, joystick, leaflet, mermaid, plotly, scene, xterm), only devDependencies changed (rollup
4.52→4.59, rimraf6.0→6.1), so dist output is identical to main — as expected (I initially thought all elements must change) echartrequired--legacy-peer-depsdue toecharts-gl@2.0.9requiring peerecharts@^5whilepackage.jsonspecifiesecharts@^6(pre-existing on main, not introduced by this branch, but can we fix one day?)- For codemirror and json_editor, dist files differ from main: codemirror due to rollup chunk-hash changes, json_editor due to new
overrides(ajv, svelte) - Working tree is clean after all rebuilds — committed dist files match fresh build output
Collaborator
|
echarts-gl for echarts v6 is coming soon: ecomfe/echarts-gl#561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix Dependabot security alerts for transitive dependency vulnerabilities:
Implementation
Bumped
rimraf,rollup, andsvelteversion constraints in allpackage.jsonfiles acrossnicegui/elements/andexamples/, then regenerated lock files and rebuilt dist bundles.Progress
Note
I would have pushed directly to main, but we better wait for the CI to confirm that nothing after rebundling so many elements.