Redacting customer information when hide_user_data_from_log is true in rdb.c, networking.c, debug.c and t_hash

[zackcam]

Removing logging key names when hide_user_data_from_log is true in rdb.c file as well as networking.c, t_hash.c and debug.c files

Made simple if else in order to distinguish for read ability

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 849eaae9-5448-44d5-92cd-be3566e01ebe

📥 Commits

Reviewing files that changed from the base of the PR and between 0d6fe00 and 175928e.

📒 Files selected for processing (4)

• src/debug.c
• src/networking.c
• src/rdb.c
• src/t_hash.c

🚧 Files skipped from review as they are similar to previous changes (4)

• src/debug.c
• src/networking.c
• src/t_hash.c
• src/rdb.c

---

📝 Walkthrough

Walkthrough

This PR redacts user/key/query contents from selected logs when server.hide_user_data_from_log is enabled, adjusting RDB save/load warnings, stream consumer-group reports, runtime debug key prints, networking QB-limit warnings, and a hash listpack diagnostic.

Changes

Logging privacy redaction

Layer / File(s)	Summary
RDB save path: key-version warning src/rdb.c	rdbSaveKeyValuePair() now emits the key-version incompatibility warning in a generic form when server.hide_user_data_from_log is set; otherwise it includes the key string.
RDB load path: empty/duplicate key and stream-cg warnings src/rdb.c	RDB loader messages for RDB_LOAD_ERR_EMPTY_KEY, duplicated-key detection, and duplicated stream consumer-group name reports now omit the key/group name when server.hide_user_data_from_log is enabled.
Runtime debug: found-key context printing src/debug.c	logCurrentClient() prints a fixed key '*redacted*' message when server.hide_user_data_from_log is set; otherwise it logs the actual key and object debug info.
Networking: query-buffer limit warning src/networking.c	handleQbLimitReached() no longer logs a c->querybuf preview when server.hide_user_data_from_log is set; it logs a generic client-closing message instead.
Hash corruption diagnostic src/t_hash.c	The serverLogHexDump diagnostic for duplicated listpack elements is skipped when server.hide_user_data_from_log is enabled; the serverPanic("Listpack corruption detected") behavior is unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main objective: redacting customer information when hide_user_data_from_log is true across multiple files (rdb.c, networking.c, debug.c, and t_hash).
Description check	✅ Passed	The description is directly related to the changeset, explaining the removal of key names from logs when hide_user_data_from_log is enabled and mentioning the implementation approach.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/rdb.c (1)

1221-1226: Request @core-team architectural review.

Changes to rdb.c require architectural review by the core team. As per coding guidelines: "Request @core-team architectural review for changes to cluster*.c, replication.c, rdb.c, or aof.c"

Also applies to: 3465-3471, 3516-3520

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/rdb.c` around lines 1221 - 1226, This change touches rdb.c (lines around
server.hide_user_data_from_log and the serverLog calls) and therefore requires
an explicit `@core-team` architectural review per project guidelines; update the
PR description and/or add a top-level review request so the core team is
notified (mention `@core-team` and note the modified symbols:
server.hide_user_data_from_log and the serverLog warning messages that print
key/db/rdbver) and ensure you include the other affected hunks (around the same
file at the other occurrences referenced) in the review request.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/rdb.c`:
- Around line 1221-1226: This change touches rdb.c (lines around
server.hide_user_data_from_log and the serverLog calls) and therefore requires
an explicit `@core-team` architectural review per project guidelines; update the
PR description and/or add a top-level review request so the core team is
notified (mention `@core-team` and note the modified symbols:
server.hide_user_data_from_log and the serverLog warning messages that print
key/db/rdbver) and ensure you include the other affected hunks (around the same
file at the other occurrences referenced) in the review request.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 059afe18-559e-46ed-9158-61b6a0293769

📥 Commits

Reviewing files that changed from the base of the PR and between 7c3821f and e5e5625.

📒 Files selected for processing (1)

• src/rdb.c

[coderabbitai]

Actionable comments posted: 0

[coderabbitai]

Actionable comments posted: 0

[codecov]

Codecov Report

❌ Patch coverage is 26.08696% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.53%. Comparing base (e4fdae4) to head (175928e).
⚠️ Report is 1 commits behind head on unstable.

Files with missing lines	Patch %	Lines
src/rdb.c	23.07%	10 Missing ⚠️
src/debug.c	0.00%	3 Missing ⚠️
src/t_hash.c	0.00%	3 Missing ⚠️
src/networking.c	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #3872      +/-   ##
============================================
- Coverage     76.69%   76.53%   -0.16%     
============================================
  Files           162      162              
  Lines         80679    80694      +15     
============================================
- Hits          61874    61760     -114     
- Misses        18805    18934     +129     

Files with missing lines	Coverage Δ
src/networking.c	92.19% <75.00%> (+0.06%)	⬆️
src/debug.c	55.41% <0.00%> (+0.24%)	⬆️
src/t_hash.c	95.35% <0.00%> (-0.08%)	⬇️
src/rdb.c	76.59% <23.07%> (-0.57%)	⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.