Skip to content

Fix flaky block_keyspace_notification test for HGETDEL notify race#3766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enjoy-binbin merged 1 commit into from
May 19, 2026
Merged

Fix flaky block_keyspace_notification test for HGETDEL notify race #3766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/unit/moduleapi/block_keyspace_notification.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,14 @@ start_server {tags {"modules"}} {
# HGETDEL
r b_keyspace.clear
assert_equal "v2" [r hgetdel h1 FIELDS 1 f2]
# "hdel" and "del" notifications can be recorded in either order
# because they run on independent background threads.
# "hdel" and "del" notifications run on independent background threads.
# The client is unblocked by the "hdel" thread, so by the time HGETDEL
# returns the "del" thread may not have logged yet — wait for both.
wait_for_condition 50 100 {
[llength [r b_keyspace.events]] >= 2
} else {
fail "Did not see both hdel and del events: [r b_keyspace.events]"
}
assert_equal [lsort {{event hdel key h1} {event del key h1}}] [lsort [r b_keyspace.events]]
assert_equal "0" [r exists h1]

Expand Down
Loading