Custom FileSystem callbacks - #67
Merged
Merged
Conversation
Signed-off-by: Tristan Grespinet <dev003@infra.utopia-rise.com>
Still need a major rework in 2.0
CedNaru
marked this pull request as ready for review
January 27, 2021 09:53
Member
Author
|
I confirm that it properly runs on Android. |
piiertho
requested changes
Jan 27, 2021
Member
|
Only few changes but overall looks good ! |
piiertho
approved these changes
Jan 28, 2021
piiertho
reviewed
Jan 28, 2021
| } | ||
|
|
||
| extern "C" void GDN_EXPORT fmod_gdnative_terminate(godot_gdnative_terminate_options *o){ | ||
| delete Callbacks::GodotFileRunner::get_singleton(); |
Member
There was a problem hiding this comment.
Approved too quickly, singleton is now on stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #49
This PR implements FMOD filesystem callbacks. They replace the default behavior of FMOD when it tries to open files. Now, Godot will be the one opening the files and sending their content to FMOD.
With this, it's possible to open any file as you would normally do with Godot. Exported projects should work as well, it's no longer necessary to have the files next to the game executable, the pck file is enough.
When exporting a project, don't forget to add .bank and .ogg files in the options, otherwise Godot won't include them.
A draft, for now, I need to properly test that on Android and tidy the code a little.