Scope onnx-simplifier requirements check#4730
Merged
Merged
Conversation
Export.py has been updated to check for onnx-simplifier requirement only when the --simplify argument is added. Allows for better flexibility and one less requirement if simplify is not needed.
Contributor
There was a problem hiding this comment.
👋 Hello @Zegorax, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
onnx-simplifier requirements check
Member
|
@Zegorax PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Member
|
@Zegorax was thinking about this, it's a bit of a mixed result. If a user does not --simplify then we've improved things for them, if they do --simplify then we've doubled the calls to check_requirements(), and it will report twice independently as well, i.e. (1 package updated, 1 package updated) rather than combined (2 packages updated). |
Contributor
Author
|
@glenn-jocher Yes, thanks a lot for the merge. I believe it's better like this and doesn't force to have onnx-simplifier if it is not needed. |
CesarBazanAV
pushed a commit
to CesarBazanAV/yolov5
that referenced
this pull request
Sep 29, 2021
* Changed onnx-simplifier check behavior Export.py has been updated to check for onnx-simplifier requirement only when the --simplify argument is added. Allows for better flexibility and one less requirement if simplify is not needed. * Fix single-element tuples Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* Changed onnx-simplifier check behavior Export.py has been updated to check for onnx-simplifier requirement only when the --simplify argument is added. Allows for better flexibility and one less requirement if simplify is not needed. * Fix single-element tuples Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export.py has been updated to check for onnx-simplifier requirement only when the --simplify argument is added.
Allows for better flexibility and one less requirement if simplify is not needed.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improvements to ONNX export dependencies management in YOLOv5.
📊 Key Changes
onnx-simplifierfrom the immediate dependency check during ONNX export.onnx-simplifieronly when simplification is required.🎯 Purpose & Impact