fix: don't panic on a constant non-bool condition - #1729
Open
Endika wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-bool condition in
iforforis reported as an error when it is a variable, butcrashes when it is a constant:
Expected, and what
var i int; if i {}already produces today:4:5: non-bool used as if condition. String, float and typed constants panic the same way, and so do theforforms.Since the panic escapes, it takes down a host program that embeds yaegi.
The check records the error but does not stop the case, so execution reaches the
compile-time-constant fast path and calls
rval.Bool()on a value that is not a bool. Anon-constant condition has no valid
rvaland takes theelsebranch, which is why only theconstant case crashes. This is the part left uncovered when #438 was fixed.
The fix breaks out of the case as soon as the error is recorded, as the other
cfgErrorfsitesin this switch already do, for all eight condition forms. Five
_testfiles cover the plainif, theif/elseform,ifwith an init statement, the bareforand the three-clausefor.