Skip to content

Fix some back button issues#977

Merged
hjiangsu merged 1 commit into
thunder-app:developfrom
micahmo:fix/back
Dec 15, 2023
Merged

Fix some back button issues#977
hjiangsu merged 1 commit into
thunder-app:developfrom
micahmo:fix/back

Conversation

@micahmo

@micahmo micahmo commented Dec 13, 2023

Copy link
Copy Markdown
Member

Pull Request Description

Like #907, this PR adds support for the Android back button to close the user sidebar.

This also fixes an issue with community pages where the sidebar closing would take priority even if there were another page on top of the navigation stack.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_UH0AvNmIdq.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit f42b1c5 into thunder-app:develop Dec 15, 2023
@micahmo micahmo deleted the fix/back branch December 15, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants