Feature/settings account#966
Merged
Merged
Conversation
micahmo
force-pushed
the
feature/settings-account
branch
from
8c2cba0 to
2cbc212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds access to the user account settings from the main settings page. Since they are not necessarily obvious from the profile page, and since this is where the rest of the settings live, I think it makes sense to have a link here too. The page does make it clear that these particular settings sync to the Lemmy account. There is also handling for when the user isn't logged in.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
qemu-system-x86_64_IKG9TcQmOH.mp4
Checklist
semanticLabels where applicable for accessibility?