Feature/highlight current drawer#731
Merged
hjiangsu merged 3 commits intoSep 14, 2023
Merged
Conversation
…/micahmo/thunder into feature/highlight-current-drawer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Since the nav drawer is a bit of a different way to navigate (i.e., by replacing the main page), it can sometimes be a bit confusing "where" you are (especially as illustrated by some comments in #375). One small touch to help keep us grounded is to highlight the current selection in the drawer.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
qemu-system-x86_64_JGBhy9toP8.mp4
Checklist
semanticLabels where applicable for accessibility?