Skip to content

Add semantic label to combined FAB#713

Merged
hjiangsu merged 1 commit into
thunder-app:developfrom
micahmo:fix/combined-fab-semantic-label
Sep 7, 2023
Merged

Add semantic label to combined FAB#713
hjiangsu merged 1 commit into
thunder-app:developfrom
micahmo:fix/combined-fab-semantic-label

Conversation

@micahmo

@micahmo micahmo commented Sep 7, 2023

Copy link
Copy Markdown
Member

Pull Request Description

Fixes an issue reported by @shortwavesurfer2009 where the combined FAB had no semantic label.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

image

Checklist

  • Did you update CHANGELOG.md? -- N/A - new feature
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 76292c6 into thunder-app:develop Sep 7, 2023
@micahmo micahmo deleted the fix/combined-fab-semantic-label branch September 7, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants