Skip to content

Refactor EnumeratedList into List-like container with injectable EnumeratedListRow - #90

Merged
GiuliaAriu merged 6 commits into
masterfrom
fix-a11y-on-enumerated-list
May 12, 2026
Merged

Refactor EnumeratedList into List-like container with injectable EnumeratedListRow#90
GiuliaAriu merged 6 commits into
masterfrom
fix-a11y-on-enumerated-list

Conversation

@GiuliaAriu

Copy link
Copy Markdown
Contributor

No description provided.

@GiuliaAriu
GiuliaAriu requested a review from OguzYuuksel May 4, 2026 15:40
@OguzYuuksel

OguzYuuksel commented May 10, 2026

Copy link
Copy Markdown
Contributor

I think it is not nice idea to pass accessibility payloads via init.
Is there any way to handle that internally?
such as

    .accessibilityElement(children: .ignore)
    .accessibilityLabel(Text("Step \(index + 1) of \(count), \(description)"))

hmm then the problem is l10n, not a good idea.

I think this list definition is a bit problematic, we cannot reach steps from outside so we cannot pass label freely.
If you have time this components definitely worth of a clean up, if not let me know then we can merge that and complete cleanup later.

@GiuliaAriu GiuliaAriu self-assigned this May 11, 2026
Comment thread Sources/UIExtensions/Components/SwiftUI/Pure/EnumeratedList.swift
@GiuliaAriu
GiuliaAriu merged commit f2acea6 into master May 12, 2026
@GiuliaAriu GiuliaAriu changed the title Combine accessibility elements in enumerated list Refactor EnumeratedList into List-like container with injectable EnumeratedListRow May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants