Feature: Check that specific object present in List#2902
Merged
krmahadevan merged 1 commit intoApr 28, 2023
Conversation
2a163e2 to
ab8673d
Compare
68fe543 to
c12d8e1
Compare
…k if specific object present in List
0851d39 to
4c61314
Compare
juherr
approved these changes
Apr 27, 2023
juherr
left a comment
Member
There was a problem hiding this comment.
Why not but we recommend to use assertj
Contributor
Author
You right, but nice to have a built in feature, because not always possible to add a new library) |
krmahadevan
approved these changes
Apr 28, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Check that specific object present in List
Motivation
It's a common use case to check if some object present in list. There are objects with overridden and not overridden
equals()&hashCode().So is very repeating operation to write code as:
Assert.assertTrue(list.stream().anyMatch(user -> user.name.equals(userName)), "list not contains user");Assert.assertTrue(list.contains(user), "list not contains user");I propose to add methods to simplify this action and convenient use:
Assert.assertListContains(users, user -> user.name.equals(userName), "user " + userName);Assert.assertListContainsObject(users, user, "user " + user.name);assertListContainsuses a PredicateassertListContainsObjectusescontains()method ofListDid you remember to?
CHANGES.txt./gradlew autostyleApply