fix: Remove unused <use> elements when deleting empty symbols (issue 1765).#2051
Merged
Merged
Conversation
SethFalco
force-pushed
the
removeEmptyContainers
branch
from
26a98ea to
36a0a0a
Compare
Member
|
This looks great to me! Thank you very much for your contribution! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removeEmptyContainers removes a symbol referenced by
<use>, the stray<use>s were being left in the SVG, though they no longer reference a valid element. This PR modifies removeEmptyContainers to also remove the dangling<use>elements.Closes #1765, closes #1618, closes #1194.