Skip to content

Accept JsonProvider upon JsonProjectingMethodInterceptorFactory creation#2403

Closed
sokomishalov wants to merge 1 commit into
spring-projects:mainfrom
sokomishalov:bugfix/respect-classpath-conditions
Closed

Accept JsonProvider upon JsonProjectingMethodInterceptorFactory creation#2403
sokomishalov wants to merge 1 commit into
spring-projects:mainfrom
sokomishalov:bugfix/respect-classpath-conditions

Conversation

@sokomishalov

@sokomishalov sokomishalov commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

It causes NCDFE in the case of excluding json-smart from the classpath.
While calling Configuration::build without providing JsonProvider it takes the default one (JsonSmartJsonProvider) with bad consequences for spring-boot context initialization (like that)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 6, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 13, 2021
@mp911de mp911de self-assigned this Jul 13, 2021
@mp911de mp911de added this to the 2.6 M1 (2021.1.0) milestone Jul 13, 2021
@mp911de mp911de changed the title Use JacksonJsonProvider in case of having jackson in the classpath Accept JsonProvider upon JsonProjectingMethodInterceptorFactory creation Jul 13, 2021
@mp911de mp911de closed this in f919013 Jul 13, 2021
mp911de added a commit that referenced this pull request Jul 13, 2021
Un-deprecate constructor. Rearrange method arguments to match parameter significance. Reformat code, replace space indents with tabs.

Original pull request: #2403.
mp911de pushed a commit that referenced this pull request Jul 13, 2021
…ion.

We now configure explicitly the JsonProvider that is used by JSONPath through JsonProjectingMethodInterceptorFactory to avoid misconfiguration due to JSONPath defaulting attempts. Accepting JsonProvider allows for improved flexibility during configuration.

Closes #2403
mp911de added a commit that referenced this pull request Jul 13, 2021
Un-deprecate constructor. Rearrange method arguments to match parameter significance. Reformat code, replace space indents with tabs.

Original pull request: #2403.
@mp911de

mp911de commented Jul 13, 2021

Copy link
Copy Markdown
Member

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants