Created StackTracePrinter instances have no access to the Environment#50303
Merged
philwebb merged 1 commit intoMay 12, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
mheath
force-pushed
the
custom_stacktraceprinter_with_environment
branch
from
59bddbd to
39ffa3e
Compare
philwebb
changed the title
philwebb
added
type: bug
Member
|
Thanks @mheath! I think I consider this a bug of omission, especially as the fix looks pretty minimal. I'll try to get it into 3.5.x. |
Member
|
@mheath Are you able to add a DCO line to your commit? "Signed-off-by: Author Name authoremail@example.com". |
philwebb
added
the
status: blocked
mheath
force-pushed
the
custom_stacktraceprinter_with_environment
branch
from
39ffa3e to
cdef06f
Compare
Contributor
Author
|
@philwebb Done. |
See spring-projectsgh-50303 Signed-off-by: mheath <elcapo@gmail.com>
philwebb
force-pushed
the
custom_stacktraceprinter_with_environment
branch
from
cdef06f to
686db1e
Compare
philwebb
removed
the
status: blocked
Member
|
Thanks! This has now been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Being able to create a StackTracePrinter that delegates to the StandardStackTracePrinter lacks flexibility because the custom StackTracePrinter does not have access to the Environment. This change add the Environment to the StackTracePrinter instantiator so that custom StackTracePrinter implementations can customize the StandardStackTracePrinter according to environment property values.