Skip to content

Add iss claim support for WIT-SVIDs - #6857

Merged
sorindumitru merged 2 commits into
spiffe:mainfrom
kanywst:feat/wit-svid-iss-claim
May 1, 2026
Merged

Add iss claim support for WIT-SVIDs#6857
sorindumitru merged 2 commits into
spiffe:mainfrom
kanywst:feat/wit-svid-iss-claim

Conversation

@kanywst

@kanywst kanywst commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality
WIT-SVID minting

Description of change
Adds a wit_issuer option under experimental, same as jwt_issuer for JWT-SVIDs.
When set, the iss claim is included in minted WIT-SVIDs.

Which issue this PR fixes
#6856

@sorindumitru

Copy link
Copy Markdown
Member

Thanks @kanywst for the changes. Out of curiosity, are you planning on using the iss claim for something?

Comment thread pkg/server/credtemplate/builder_test.go
@kanywst
kanywst force-pushed the feat/wit-svid-iss-claim branch from 06bf760 to 07e9dc2 Compare April 21, 2026 23:14
@kanywst

kanywst commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

@sorindumitru

Thanks for the review! I was looking at the WIT-SVID implementation and noticed there was no iss claim support unlike JWT-SVIDs. I thought it'd be useful to have the same option available.

@kanywst
kanywst force-pushed the feat/wit-svid-iss-claim branch from 07e9dc2 to 1105c9a Compare April 23, 2026 14:59

@sorindumitru sorindumitru left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kanywst!

@sorindumitru
sorindumitru added this pull request to the merge queue May 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 1, 2026
kanywst added 2 commits May 1, 2026 10:58
Signed-off-by: kanywst <niwatakuma@icloud.com>
Signed-off-by: kanywst <niwatakuma@icloud.com>
@sorindumitru
sorindumitru force-pushed the feat/wit-svid-iss-claim branch from 1105c9a to 856e82a Compare May 1, 2026 09:58
@sorindumitru sorindumitru added this to the 1.15.0 milestone May 1, 2026
@sorindumitru
sorindumitru enabled auto-merge May 1, 2026 09:58
@sorindumitru
sorindumitru added this pull request to the merge queue May 1, 2026
Merged via the queue into spiffe:main with commit e6854ba May 1, 2026
50 checks passed
@kanywst
kanywst deleted the feat/wit-svid-iss-claim branch May 1, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants