Skip to content

using # needs in posets folder - #36114

Merged
vbraun merged 5 commits into
sagemath:developfrom
fchapoton:needs_in_posets
Aug 27, 2023
Merged

using # needs in posets folder#36114
vbraun merged 5 commits into
sagemath:developfrom
fchapoton:needs_in_posets

Conversation

@fchapoton

Copy link
Copy Markdown
Contributor

using the needs directive in posets folder

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Comment thread src/sage/combinat/posets/posets.py Outdated
@fchapoton

Copy link
Copy Markdown
Contributor Author

better now ?

Comment thread src/sage/combinat/posets/posets.py Outdated
Comment thread src/sage/combinat/posets/posets.py Outdated
Comment thread src/sage/combinat/posets/posets.py
Comment thread src/sage/combinat/posets/posets.py
@mkoeppe

mkoeppe commented Aug 25, 2023

Copy link
Copy Markdown
Contributor
File "sage/combinat/posets/posets.py", line 3719, in sage.combinat.posets.posets.FinitePoset.Integer
Failed example:
    needs sage.groups sage.libs.flint
Exception raised:
    Traceback (most recent call last):
      File "/sage/src/sage/doctest/forker.py", line 709, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/sage/src/sage/doctest/forker.py", line 1142, in compile_and_execute
        compiled = compiler(example)
      File "/sage/src/sage/doctest/forker.py", line 676, in compiler
        code = compile(example.source, filename, "single",
      File "<doctest sage.combinat.posets.posets.FinitePoset.Integer[0]>", line 1
        needs sage.groups sage.libs.flint
              ^
    SyntaxError: invalid syntax
**********************************************************************
File "sage/combinat/posets/posets.py", line [37](https://github.com/sagemath/sage/actions/runs/5978963391/job/16222089762?pr=36114#step:14:38)37, in sage.combinat.posets.posets.FinitePoset.Integer
Failed example:
    needs sage.groups sage.libs.flint
Exception raised:
    Traceback (most recent call last):
      File "/sage/src/sage/doctest/forker.py", line 709, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/sage/src/sage/doctest/forker.py", line 1142, in compile_and_execute
        compiled = compiler(example)
      File "/sage/src/sage/doctest/forker.py", line 676, in compiler
        code = compile(example.source, filename, "single",
      File "<doctest sage.combinat.posets.posets.FinitePoset.Integer[8]>", line 1
        needs sage.groups sage.libs.flint
              ^
    SyntaxError: invalid syntax

needs needs #

@github-actions

Copy link
Copy Markdown

Documentation preview for this PR (built with commit b42148c; changes) is ready! 🎉

@mkoeppe mkoeppe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@vbraun
vbraun merged commit 1e6119e into sagemath:develop Aug 27, 2023
@fchapoton
fchapoton deleted the needs_in_posets branch August 28, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants