You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some basic modules of sage.combinat (.permutation, .combination, etc.) are needed in the distribution sagemath-categories (as of #35095). We make them importable (by splitting a Cython module into several parts and by using lazy imports) and separately testable (using # optional doctest directives).
Likewise, split the parts of sage.combinat.posets.hasse_cython that need the FLINT library out as a separate module (this is for the package sagemath-graphs in #35095)
I don't know; the source file from which I split it out did not have this directive if I'm not mistaken.
I'll be happy to add it to if you recommend it?
I had to add # cython: binding=True in some .pyx files in order to import some methods from the console, e.g., with from sage.graphs.graph_decompositions.cutwidth import cutwidth. This is convenient in some cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Some basic modules of
sage.combinat(.permutation,.combination, etc.) are needed in the distribution sagemath-categories (as of #35095). We make them importable (by splitting a Cython module into several parts and by using lazy imports) and separately testable (using# optionaldoctest directives).Likewise, split the parts of
sage.combinat.posets.hasse_cythonthat need the FLINT library out as a separate module (this is for the package sagemath-graphs in #35095)sage.misc.misc,sage.combinat: Modularization fixes #35564📝 Checklist
⌛ Dependencies