Skip to content

sage.rings.factorint: Modularization fixes - #35502

Merged
vbraun merged 6 commits into
sagemath:developfrom
mkoeppe:factorint_flint_separate
May 22, 2023
Merged

sage.rings.factorint: Modularization fixes#35502
vbraun merged 6 commits into
sagemath:developfrom
mkoeppe:factorint_flint_separate

Conversation

@mkoeppe

@mkoeppe mkoeppe commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

📚 Description

Spliiting sage.rings.factorint into separate modules, per library used.

Part of:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@Drewshotwell

Copy link
Copy Markdown

This is looking good from my testing. The only thing I noticed is that in the Examples section it's still sage: from sage.rings.factorint import factor_using_flint when it should be sage: from sage.rings.factorint_flint import factor_using_flint

@mkoeppe

mkoeppe commented Apr 23, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for catching this; fixed now

@kwankyu

kwankyu commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

Please add boilerplate head stuffs, especially copyright notice.

Matthias Koeppe added 2 commits April 23, 2023 19:26
SageMath version 10.0.rc0, Release Date: 2023-04-23
…-M -C src/sage/rings/factorint.pyx -w --date=format:%Y 10.0.rc0 | sort -k2'
@mkoeppe

mkoeppe commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

Thanks, done.

@github-actions

Copy link
Copy Markdown

Documentation preview for this PR is ready! 🎉
Built with commit: e8051b8

@kwankyu kwankyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@mkoeppe

mkoeppe commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

Thank you!

@vbraun
vbraun merged commit 07bd424 into sagemath:develop May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants