feat: confirmation prompt for deleting selected notes#1100
Merged
Conversation
ZebraVogel94349
force-pushed
the
deletion
branch
4 times, most recently
from
6e1faf3 to
6e02227
Compare
Contributor
Author
|
I've updated this pull request to pass all tests and to make it possible to merge without conflicts again. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 51.93% 51.79% -0.15%
==========================================
Files 130 131 +1
Lines 9387 9413 +26
==========================================
Hits 4875 4875
- Misses 4512 4538 +26 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a confirmation prompt for deleting selected notes, so you cannot accidentally delete notes by miss clicking if you want to export or move them. The prompt works exactly like the one for deleting folders.