internal: support RUSTFMT_TOOLCHAIN for xtask codegen#22074
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Apr 17, 2026
rustbot
removed
the
S-waiting-on-review
Veykril
reviewed
Apr 17, 2026
| let sh = Shell::new().unwrap(); | ||
| let rustfmt_toml = project_root().join("rustfmt.toml"); | ||
| let version = cmd!(sh, "rustup run stable rustfmt --version").read().unwrap_or_default(); | ||
| let toolchain = &std::env::var("RUSTFMT_TOOLCHAIN").unwrap_or("stable".to_owned()); |
Member
There was a problem hiding this comment.
What is this env var? I never heard of that, if anything we should allow RUSTFMT I think, as that is also how RUSTC and CARGO env vars tend to be
Member
Author
There was a problem hiding this comment.
I haven't investigated the source of this variable,
I just hope a temporary variable like UPDATE_EXPECT can be used to adjust the toolchain
Because I only use nightly, I want to run RUSTFMT_TOOLCHAIN=nightly cargo codegen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.