Conversation
Test Results 203 files ± 0 203 suites ±0 9m 45s ⏱️ -12s Results for commit 51a29ea. ± Comparison against base commit c06bc2c. This pull request skips 447 tests.♻️ This comment has been updated with latest results. |
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
ggivo
left a comment
There was a problem hiding this comment.
Looks good,
Added some notes, let's add integration tests for binary variants also.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 51a29ea. Configure here.
| @Mock protected CommandObject<Double> doubleCommandObject; | ||
| @Mock protected CommandObject<FunctionStats> functionStatsCommandObject; | ||
| @Mock protected CommandObject<List<Double>> increxDoubleListCommandObject; | ||
| @Mock protected CommandObject<List<Long>> increxLongListCommandObject; |
There was a problem hiding this comment.
Redundant mock fields duplicate existing typed mocks
Low Severity
increxDoubleListCommandObject and increxLongListCommandObject are CommandObject<List<Double>> and CommandObject<List<Long>> respectively — the exact same types as the already-existing listDoubleCommandObject (line 67) and listLongCommandObject (line 76). Every other mock in this shared base class follows a type-based naming convention (e.g., listStringCommandObject, longCommandObject). The existing mocks could be reused in the INCREX tests instead of introducing feature-prefixed duplicates.
Reviewed by Cursor Bugbot for commit 51a29ea. Configure here.


Note
Medium Risk
Adds a new Redis command surface (
INCREX) acrossJedis/UnifiedJedis/pipelining plus new parameter builders; changes touch core protocol enums and command construction, so regressions would mainly be in command argument encoding and response parsing.Overview
Adds client support for Redis
INCREX, including newStringCommands/StringBinaryCommands/pipeline APIs and corresponding implementations inJedis,UnifiedJedis,PipeliningBase, andCommandObjects(integer and float variants returning[newValue, appliedIncrement]).Introduces
IncrexParams/IncrexFloatParams(viaBaseIncrexParams) to encode bounds,SATURATE, and expiration controls (includingENX), extendsProtocolwith the new command/keywords, and adds comprehensive integration + mocked tests;pom.xmlformatter includes are updated to cover the new*Increx*files.Reviewed by Cursor Bugbot for commit 51a29ea. Bugbot is set up for automated code reviews on this repo. Configure here.