Add support for CONFIG GET and SET commands in UnifiedJedis#4518
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
ggivo
reviewed
May 20, 2026
ggivo
left a comment
Collaborator
There was a problem hiding this comment.
Do we want/need to expose CONFIG GET/SET for RedisCluster as well?
CONFIG GET responses can differ across nodes and cannot be meaningfully aggregated. If exposed on RedisCluster, the default behavior would effectively be executing against a random node, which may be surprising.
How about exposing CONFIG GET/SET only for RedisClient for now and marking them as experimental?
ggivo
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds new
CONFIG GET/map-basedCONFIG SETAPIs that can mutate Redis server configuration and have non-obvious behavior in OSS Cluster (keyless command routed to a single shard). Changes are additive but touch server-management command execution and add new integration coverage across topologies/RESP versions.Overview
UnifiedJedisnow exposesCONFIG GET(single and varargs patterns) and a new overload ofCONFIG SETthat accepts aMap<String,String>for setting multiple parameters in one call.CommandObjectsadds the correspondingCommandObjectbuilders (usingBuilderFactory.STRING_MAPfor GET and iterating map entries for SET), and the PR introduces new mocked tests plus integration test suites that run against both standalone and OSS Cluster for RESP2/RESP3, including wildcard/unknown-parameter cases and multi-parameter set/restore behavior.Reviewed by Cursor Bugbot for commit 063e4de. Bugbot is set up for automated code reviews on this repo. Configure here.