Skip to content

Add support for CONFIG GET and SET commands in UnifiedJedis#4518

Merged
uglide merged 10 commits into
masterfrom
im/add-config-get-to-unifiedjedis
May 21, 2026
Merged

Add support for CONFIG GET and SET commands in UnifiedJedis#4518
uglide merged 10 commits into
masterfrom
im/add-config-get-to-unifiedjedis

Conversation

@uglide

@uglide uglide commented May 8, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Adds new CONFIG GET/map-based CONFIG SET APIs that can mutate Redis server configuration and have non-obvious behavior in OSS Cluster (keyless command routed to a single shard). Changes are additive but touch server-management command execution and add new integration coverage across topologies/RESP versions.

Overview
UnifiedJedis now exposes CONFIG GET (single and varargs patterns) and a new overload of CONFIG SET that accepts a Map<String,String> for setting multiple parameters in one call.

CommandObjects adds the corresponding CommandObject builders (using BuilderFactory.STRING_MAP for GET and iterating map entries for SET), and the PR introduces new mocked tests plus integration test suites that run against both standalone and OSS Cluster for RESP2/RESP3, including wildcard/unknown-parameter cases and multi-parameter set/restore behavior.

Reviewed by Cursor Bugbot for commit 063e4de. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

Test Results

  197 files  + 2    197 suites  +2   8m 59s ⏱️ -33s
7 319 tests +24  6 469 ✅ +24  850 💤 ±0  0 ❌ ±0 
7 327 runs  +24  6 469 ✅ +24  858 💤 ±0  0 ❌ ±0 

Results for commit 063e4de. ± Comparison against base commit e390965.

♻️ This comment has been updated with latest results.

@jit-ci

jit-ci Bot commented May 8, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@uglide uglide changed the title Add support for CONFIG GET command in UnifiedJedis Add support for CONFIG GET and SET commands in UnifiedJedis May 20, 2026

@ggivo ggivo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want/need to expose CONFIG GET/SET for RedisCluster as well?

CONFIG GET responses can differ across nodes and cannot be meaningfully aggregated. If exposed on RedisCluster, the default behavior would effectively be executing against a random node, which may be surprising.

How about exposing CONFIG GET/SET only for RedisClient for now and marking them as experimental?

Comment thread src/test/java/redis/clients/jedis/commands/unified/ConfigCommandsTestBase.java Outdated
@uglide uglide merged commit 99e8cc3 into master May 21, 2026
18 of 19 checks passed
@uglide uglide deleted the im/add-config-get-to-unifiedjedis branch May 21, 2026 08:59
@ggivo ggivo added this to the 8.0.0 milestone May 27, 2026
@ggivo ggivo added the feature label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants