test added for SslOptions.defaults()#4498
Merged
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Test-only changes that validate TLS defaults and expected connection failures; low risk aside from potential CI flakiness due to environment-dependent TLS/hostname behavior.
Overview
Adds new TLS integration tests for
RedisClientthat exerciseSslOptions.defaults()(successful connect, failure on hostname mismatch) and a custom truststore configuration.Updates the cluster TLS integration test to stop explicitly supplying
SSLParameterswithHTTPSendpoint identification, relying onSslOptions/client defaults instead.Reviewed by Cursor Bugbot for commit c587922. Bugbot is set up for automated code reviews on this repo. Configure here.