Skip to content

test added for SslOptions.defaults()#4498

Merged
ggivo merged 1 commit into
masterfrom
topic/ggivo/ssloptions-default-tests
Apr 28, 2026
Merged

test added for SslOptions.defaults()#4498
ggivo merged 1 commit into
masterfrom
topic/ggivo/ssloptions-default-tests

Conversation

@ggivo

@ggivo ggivo commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

Note

Low Risk
Test-only changes that validate TLS defaults and expected connection failures; low risk aside from potential CI flakiness due to environment-dependent TLS/hostname behavior.

Overview
Adds new TLS integration tests for RedisClient that exercise SslOptions.defaults() (successful connect, failure on hostname mismatch) and a custom truststore configuration.

Updates the cluster TLS integration test to stop explicitly supplying SSLParameters with HTTPS endpoint identification, relying on SslOptions/client defaults instead.

Reviewed by Cursor Bugbot for commit c587922. Bugbot is set up for automated code reviews on this repo. Configure here.

@jit-ci

jit-ci Bot commented Apr 24, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@github-actions

github-actions Bot commented Apr 24, 2026

Copy link
Copy Markdown

Test Results

  191 files  ±0    191 suites  ±0   11m 45s ⏱️ +12s
9 232 tests +3  9 176 ✅ +3  56 💤 ±0  0 ❌ ±0 
3 472 runs  +3  3 467 ✅ +3   5 💤 ±0  0 ❌ ±0 

Results for commit c587922. ± Comparison against base commit dd8ea11.

♻️ This comment has been updated with latest results.

@ggivo ggivo merged commit bc55240 into master Apr 28, 2026
19 checks passed
@ggivo ggivo deleted the topic/ggivo/ssloptions-default-tests branch April 28, 2026 04:44
@ggivo ggivo added the testing label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant